Skip to content

Fix associated release link on tag page

Ahmed Hemdan requested to merge fix-associated-release-link-on-tag-page into master

What does this MR do and why?

This merge request fixes the release associated link for a tag, on the tags page (#350664 (closed)).

The fix ensures we point to a permalink:

https://gitlab.com/gitlab-org/gitlab/-/releases/v13.8.0-ee

instead of a hashlink:

https://gitlab.com/gitlab-org/gitlab/-/releases#v13.8.0-ee

As the latter could point to a release that is no longer displayed on the first page due to pagination, in which case, the link leads to the releases page but not the page for that specific release (and essentially it becomes a broken link), resulting in bad user experience.

How to set up and validate locally?

  1. Start GDK locally, if it isn't up already: gdk start.
  2. Make sure one of the projects on your local installation has a tag with a release associated to it.
  3. Visit the tags page: http://127.0.0.1:3000/root/:project_name/tags.
  4. Click on the release link.
  5. Validate that it takes you to the correct link: http://127.0.0.1:3000/root/:project_name/releases/:tag_name

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ahmed Hemdan

Merge request reports