Skip to content

Update group deletion protection settings interface

Jiaan Louw requested to merge 352961-update-group-deletion-protection-settings into master

What does this MR do and why?

This MR updates the group deletion protection settings to match the designs in #352961 (closed), functionally nothing changes.

It follows the changes in !86568 (merged) that updated the admin settings interface.

Screenshots or screen recordings

Allowed to delete projects

Admins Owners and administrators
image image

Enabled instance wide

Before After
image image

Disabled instance wide

Before After
image image

Enforced for sub-groups

Before After
image image

How to set up and validate locally

Setup:

  1. Checkout this branch: 352961-update-group-deletion-protection-settings
  2. Pick a group with a subgroup, or create a subgroup. I'm using gitlab-org/gitlab-sub in this example.
  3. Open a tab for the group Deletion protection settings at: http://localhost:3000/groups/gitlab-org/-/edit#js-permissions-settings
  4. Open a tab for the subgroup Deletion protection settings at: http://localhost:3000/groups/gitlab-org/gitlab-sub/-/edit#js-permissions-settings
  5. Open a tab for the admin Deletion protection settings at: http://localhost:3000/admin/application_settings/general#js-visibility-settings

Validation:

  1. Toggle between the Admin > Allowed to delete projects options and verify that the help text changes under group Deletion protection.
  2. Check None, delete immediately in Admin > Deletion protection verify that the group Deletion protection setting is locked.
  3. Check Keep deleted groups with a number of days in Admin > Deletion protection and verify that the Group > Deletion protection setting is unlocked.
  4. Check Keep deleted groups and projects in Admin > Deletion protection and create a new group, verify that Group > Deletion protection has Keep deleted projects checked.
  5. Check Enforce deletion protection for all subgroups in the parent group's Group > Deletion protection settings and verify that the sub-group's setting is locked.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Approvals required

Edited by Jiaan Louw

Merge request reports