Skip to content

Removing permissions attribute from Secure Files model

Darby Frey requested to merge remove-secure-files-permissions into master

What does this MR do and why?

The first iteration of Secure Files had the idea of saving the intended file permissions to the database as part of the metadata for the file, but this approach is limiting and it makes the system more flexible to move that permission setting to the CI configuration as described here: #350934 (closed). This MR removes permission from the model, API, and docs.

Note: the feature is not in use yet so there will be not customer impact from removing this data.

Screenshots or screen recordings

The original video demo of this feature can be found here: https://youtu.be/eK3FUskHfdo, and the current docs can be viewed here: https://docs.gitlab.com/ee/api/secure_files.html#create-secure-file

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Darby Frey

Merge request reports