Draft: Change admin mode forms to use `_tab_single` partial and use `btn-confirm`
requested to merge 230778-change-admin-mode-forms-to-use-tab-single-partial-and-use-btn-confirm into master
What does this MR do and why?
This MR removes the _tabs_normal
partial and uses _tab_single
instead because the secondary registration tab is never used. This is because of the following discussion.
It also fixes the following UI issues:
- Makes sure the buttons are using
btn-confirm
rather thanbtn-success
- Adds padding back to the tab contents
Screenshots or screen recordings
Page | Before | After |
---|---|---|
Admin mode | ||
2FA for admin mode |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Login as an Admin and go to
[GDK_HOST]/admin/application_settings/general#js-signin-settings
- Enable admin mode and enforce two-factor authentication
- Set up 2FA for your admin account
- You will then be redirected
- Check the
Enter admin mode
tab is shown correctly on the password view - Login with your password
- Check the
Enter admin mode
tab is shown correctly on the 2FA view
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #230778 (closed)
Edited by Robert Hunt