Skip to content

Fix bug when reinstalling Slack app

Markus Koller requested to merge 355997-fix-slack-app-reinstall into master

What does this MR do and why?

The switch to create_or_load_association in !85726 (merged) introduced a bug where the Slack app could not be installed if the integration record already exists (after e.g. uninstalling the app).

This reverts to the previous behaviour where we manually fetched or created the record.

Sentry: https://sentry.gitlab.net/gitlab/gitlabcom/issues/3284004

Related to #355997 (closed)

Screenshots or screen recordings

image

How to set up and validate locally

  1. Add Slack app to a project, remove, add again

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Markus Koller

Merge request reports