Skip to content

Add tooltip on the downstream pipeline action button

What does this MR do and why?

We add a tooltip to the new downstream pipeline retry action for instead of showing the tooltip of the card which shows which job spawned the downstream pipeline. This is behind a feature flag downstream_retry_action.

Note that when you hover on the card, you see the card tooltip which shows the trigger job. If you then hover on the action button, the card tooltip disappears and we show the downstream action tooltip. But then if you move out of the action button, the card tooltip will not reappear until you mouseout of it and mouseover again. This is normal because we do not re-trigger a mouseover when you leave the action button since you are already on the card. This is a normal browser behaviour and I think it's ok like this (the code workaround would be a bit clunky) so if this is good as is, I would advise not to handle that case.

Screenshots or screen recordings

Before after
Screen_Recording_2022-05-02_at_10.21.47_AM Screen_Recording_2022-05-02_at_7.27.45_AM

How to set up and validate locally

  • Enable downstream_retry_action in rails console
  • Setup local runners on your GDK
  • Create a multi-project pipeline. Here is a simple config:
stages:
  - build
  - test
  - deploy

hi:
  stage: "test"
  script: "echo I run only on master"

hi2:
  stage: "deploy"
  script: "echo I run only on master"
  needs: ['hi']

trigger_other_project_okay_really:
  stage: deploy
  trigger:
    include:
      - project: "root/large-pipeline" # replace with another project
        file: ".gitlab-ci.yml"

Then in the other project, any config will do:

job_from_other_project:
  script: echo hello
  • Run a pipeline in your main project and wait for the pipeline to be completed
  • You will see the downstream card in the grap without any action
  • Expand the downstream card in the graph.
  • retry the job
  • Notice the downstream card will get a cancel action available
  • Hover on it
  • Notice the tooltip that says "Cancel pipeline"
  • Hover on the card
  • Notice the tooltip that shows the trigger job
  • Click cancel
  • When it's been cancelled, notice the retry action appears
  • hover on it
  • Notice the tooltip that says "Retry pipeline"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #360497 (closed)

Edited by Frédéric Caplette

Merge request reports