Skip to content
Snippets Groups Projects

Make query recorders more consistent

Merged charlie ablett requested to merge 360896-cablett-cache-middleware into master

When running tests, the cache is cleared a bit inconsistently and it can lead to some funny behaviour like !85399 (comment 927714587).

Also, some extra License checks occasionally occur due to how the cache is cleared and some interesting interactions with some other aspects of our testing suite, such as throttling user updates (e.g. last sign in).

This MR makes the cache clearing behaviour in tests more consistent and ignores License SQL calls in query recorders. It may unearth some N+1 problems. (it didn't! hooray!)

Related to #360896

Edited by charlie ablett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @alexkalderimis

  • This looks good to me - just one question about handling exceptional states.

    back to you @cablett

  • Alex Kalderimis removed review request for @alexkalderimis

    removed review request for @alexkalderimis

  • charlie ablett added 1 commit

    added 1 commit

    • 6e4632e2 - Ignore Licence loading in query recorder

    Compare with previous version

  • requested review from @alexkalderimis

  • charlie ablett added 1 commit

    added 1 commit

    • 29a7a5e9 - Ignore Licence loading in query recorder

    Compare with previous version

  • Alex Kalderimis approved this merge request

    approved this merge request

  • @engwan - can you please maintainerize?

  • Alex Kalderimis requested review from @engwan

    requested review from @engwan

  • :wave: @alexkalderimis, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Alex Kalderimis removed review request for @alexkalderimis

    removed review request for @alexkalderimis

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • added 1 commit

    • b4d98e09 - Refactor ignorable conditions

    Compare with previous version

  • Thanks @cablett, looks good to me :thumbsup:

  • Heinrich Lee Yu changed milestone to %15.0

    changed milestone to %15.0

  • added 1 commit

    Compare with previous version

  • Heinrich Lee Yu resolved all threads

    resolved all threads

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 26b4d853 succeeds

    enabled an automatic merge when the pipeline for 26b4d853 succeeds

  • Heinrich Lee Yu mentioned in commit 0657e010

    mentioned in commit 0657e010

  • Heinrich Lee Yu mentioned in commit 8bce7d2a

    mentioned in commit 8bce7d2a

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading