Make query recorders more consistent
When running tests, the cache is cleared a bit inconsistently and it can lead to some funny behaviour like !85399 (comment 927714587).
Also, some extra License checks occasionally occur due to how the cache is cleared and some interesting interactions with some other aspects of our testing suite, such as throttling user updates (e.g. last sign in).
This MR makes the cache clearing behaviour in tests more consistent and ignores License SQL calls in query recorders. It may unearth some N+1 problems. (it didn't! hooray!)
Related to #360896
Merge request reports
Activity
added devopsmanage sectiondev + 1 deleted label
assigned to @cablett
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @stanhu
,@engwan
,@mayra-cabrera
,@reprazent
,@gitlab-bot
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Edited by GitLab Reviewer-Recommender Botmentioned in issue #357923 (closed)
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Felipe Artur ( @felipe_artur
) (UTC-3, 15 hours behind@cablett
)Marc Shaw ( @marc_shaw
) (UTC+12, same timezone as@cablett
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Edited by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
Another option suggested by @alexkalderimis is ignoring License loads in QueryRecorder, a bit like in !85826 (merged).
mentioned in merge request !85399 (merged)
Is testingcode testing the correct label here?
added testingcode testing typemaintenance labels
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 7d0e8753expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 17 | 0 | 2 | 1 | ❗ | | Verify | 12 | 0 | 1 | 8 | ❗ | | Plan | 41 | 0 | 1 | 1 | ❗ | | Manage | 28 | 0 | 2 | 11 | ❗ | | Package | 24 | 0 | 1 | 24 | ❗ | | Protect | 2 | 0 | 0 | 0 | ✅ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 124 | 0 | 9 | 45 | ❗ | +----------------------+--------+--------+---------+-------+--------+
- Resolved by charlie ablett
- Resolved by charlie ablett
requested review from @alexkalderimis
mentioned in issue gitlab-org/manage/general-discussion#17406
This looks good to me - just one question about handling exceptional states.
back to you @cablett
removed review request for @alexkalderimis
requested review from @alexkalderimis
@engwan - can you please maintainerize?
requested review from @engwan
@alexkalderimis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
removed review request for @alexkalderimis
Thanks @cablett, looks good to me
changed milestone to %15.0
- Resolved by Heinrich Lee Yu
enabled an automatic merge when the pipeline for 26b4d853 succeeds
mentioned in commit 0657e010
mentioned in commit 8bce7d2a
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#13148 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label