Fix RuboCop offenses in several ErrorTracking specs

What does this MR do and why?

This MR resolves current and upcoming RuboCop rules in several Category:Error Tracking specs.

Extracted from !85907 (merged).

Please don't squash commits.

Screenshots or screen recordings

n/a

How to set up and validate locally

merge_base=$(git merge-base pl-error-tracking-rubocop-offenses origin/master)
changed=$(git diff --name-only $merge_base | grep -v yml)

$ REVEAL_RUBOCOP_TODO=1 exec rubocop $changed

Inspecting 14 files
.............C

Offenses:

spec/support/shared_contexts/sentry_error_tracking_shared_context.rb:3:22: C: RSpec/ContextWording: Start context description with 'when', 'with', or 'without'.
RSpec.shared_context 'sentry error tracking context' do
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

14 files inspected, 1 offense detected

$ REVEAL_RUBOCOP_TODO=0 bundle exec rubocop $changed
Inspecting 14 files
..............

14 files inspected, no offenses detected

bin/rspec $(tff -f tests.yml $changed)
.........................................................................................

Finished in 18.18 seconds (files took 8.61 seconds to load)
89 examples, 0 failures

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

assigned to @splattael

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Catalin Irimie (@cat) (UTC+1, 1 hour behind @splattael)	Mikołaj Wawrzyniak (@mikolaj_wawrzyniak) (UTC+2, same timezone as @splattael)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

changed title from Fix RuboCop offenses in ErrorTracking GraphQL specs to Fix RuboCop offenses in several ErrorTracking specs

changed milestone to %15.0

added Category:Error Tracking devopsmonitor groupobservability static code analysis test typemaintenance labels

@syasonik

Do you mind reviewing this MR as a domain expert?

Please feel free to assign this MR to the maintainer after your approval

requested review from @syasonik

changed the description

approved this merge request

requested review from @mkozono and removed review request for @syasonik

@syasonik, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

removed review request for @mkozono

added sectionops label

added 1 commit

• 15b2465d - squash! Fix RuboCop offenses for ErrorTracking controller specs

Compare with previous version

marked this merge request as draft from 15b2465d

requested review from @mkozono

added 135 commits

• 15b2465d...d1d01919 - 127 commits from branch master
• bb454b3f - Fix RuboCop offenses in ErrorTracking GraphQL specs
• a5741eff - Fix RuboCop offenses for ErrorTracking controller specs
• b38e14cb - Fix RuboCop offenses for DSN specs
• e2799f87 - Fix RuboCop offenses in Sentry Auth Parser specs
• 7efa8090 - Fix RuboCop offenses in Sentry Request Parser specs
• d0cae6ce - Fix RuboCop offenses for ErrorTracking BaseService specs
• 727d073c - Fix RuboCop offenses for ErrorTracking IssueUpdateService specs
• 8cee2ae9 - Fix RuboCop offenses for ErrorTracking issue service specs

Compare with previous version

Suggested Reviewers (beta)

This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

The individuals below may be good candidates to participate in the review based on various factors.

After you review all recommendations, please assign reviewers manually, as this is not done automatically.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Reviewers
@mayra-cabrera, @engwan, @stanhu, @reprazent, @dzaporozhets

If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot

marked this merge request as ready

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 5267a595 succeeds

merged

mentioned in commit d47d237c

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label