Update full-text search index when moving issues
When moving issues, we do several updates to the new issue within an
outer transaction. This caused saved_changes
to return only the
changes of the latest update even if more changes were committed.
This meant #update_search_data!
wasn't run even though we saved the
title and description of the issue.
Related to #273784 (closed)
Fixing missing data will be done in a separate MR.
Merge request reports
Activity
assigned to @engwan
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @acroitor
,@DylanGriffith
,@serenafang
,@ahegyi
,@euko
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
changed milestone to %15.0
added backend devopsplan groupproject management typebug labels
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend George Koltsov ( @georgekoltsov
) (UTC+1, 7 hours behind@engwan
)Terri Chu ( @terrichu
) (UTC-4, 12 hours behind@engwan
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermentioned in issue #360319 (closed)
- Resolved by Heinrich Lee Yu
@euko can you review this please?
requested review from @euko
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for e54c41f9+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Verify | 12 | 0 | 1 | 7 | ❗ | | Manage | 28 | 0 | 2 | 14 | ❗ | | Create | 17 | 0 | 2 | 3 | ❗ | | Plan | 41 | 0 | 1 | 1 | ❗ | | Package | 24 | 0 | 1 | 24 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 124 | 0 | 9 | 49 | ❗ | +----------------------+--------+--------+---------+-------+--------+
added sectiondev label
added workflowin review label
removed review request for @euko
- Resolved by Heinrich Lee Yu
@mkozono can you do the maintainer review please?
requested review from @mkozono
mentioned in issue #273784 (closed)
added 249 commits
-
19d6ccdb...6ee3b46b - 247 commits from branch
master
- 9062e891 - Update full-text search index when moving issues
- e54c41f9 - Improve code comment
-
19d6ccdb...6ee3b46b - 247 commits from branch
@engwan LGTM, thank you!
@mkozono
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for ddad5662 succeeds
mentioned in commit 95dfbd33
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label