Display expired artifacts message in test suite table

What does this MR do and why?

Related to #296963 (closed)

This MR builds on this backend MR to show a specific message on the suite-level view of the pipeline page's Tests tab when there are no test cases to display due to expired artifacts. The summary-level view still shows statistics for these tests in this case because we store them separately; when the artifacts have expired we can no longer show the details of each test.

This feature is behind the ci_test_report_artifacts_expired feature flag. The backend only returns the specific 404/Test report artifacts have expired response that the frontend is working off of if the feature flag is enabled, so there's no need to add another feature flag check on the frontend.

Screenshots or screen recordings

without this MR	with this MR
Screen_Recording_2022-04-25_at_17.18.18	Screen_Recording_2022-04-25_at_16.40.21

How to set up and validate locally

1. git checkout 296963-show-expired-test-report-artifacts-message-frontend
2. echo "Feature.enable(:ci_test_report_artifacts_expired)" | rails c
3. set up test reports for a project OR clone this test project
4. configure test report artifacts to expire quickly OR stub this method to return true:

diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb
index 0420bb13b81..1d6dd645c03 100644
--- a/app/models/ci/pipeline.rb
+++ b/app/models/ci/pipeline.rb
@@ -1297,9 +1297,7 @@ def authorized_cluster_agents
     end
 
     def has_expired_test_reports?
+      true
-      strong_memoize(:artifacts_expired) do
-        !has_reports?(::Ci::JobArtifact.test_reports.not_expired)
-      end
     end
 
     private

5. run a pipeline that generates a test report
6. wait for the artifact to expire (if you didn't stub has_expired_test_reports)
7. navigate to the Tests tab on the pipeline page
8. click on a test suite
9. observe the specific Test details are populated by job artifacts. The job artifacts from this pipeline are expired. message displayed in addition to the generic There are no test cases to display. message

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %15.0

added Category:Code Testing and Coverage Deferred UX Deliverable GitLab Core GitLab Free Technical Writing UX VerifyP1 backend devopsverify direction documentation featureenhancement frontend grouppipeline security missed-deliverable missed:14.10 sectionops severity3 typefeature workflowin dev + 1 deleted label

assigned to @mfluharty

marked this merge request as draft

Suggested Reviewers (beta)

This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

The individuals below may be good candidates to participate in the review based on various factors.

After you review all recommendations, please assign reviewers manually, as this is not done automatically.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Reviewers
@rkadam3, @agarciatesares, @lmejia2, @mikolaj_wawrzyniak, @ali-gitlab

If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot

changed title from Draft: Put expired artifacts message in table if provided to Draft: Display expired artifacts message in test suite table

changed the description

	1 Warning
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Diana Zubova (@dzubova) (UTC+2, 1 hour ahead of @mfluharty)	David O'Regan (@oregand) (UTC-4, 5 hours behind @mfluharty)
UX	Nadia Sotnikova (@nadia_sotnikova) (UTC+8, 7 hours ahead of @mfluharty)	No maintainer available

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 56469383 and 306c74f8

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.46 MB	3.45 MB	-5.75 KB	-0.2 %
mainChunk	1.93 MB	1.93 MB	-3.96 KB	-0.2 %

Significant Growth: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.threat_monitoring.show	1.66 MB	1.75 MB	+89.7 KB	5.3 %

New entry points: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.wikis.edit	0 Bytes	1.36 MB	+1.36 MB	100.0 %
pages.groups.wikis.edit	0 Bytes	1.26 MB	+1.26 MB	100.0 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for 56469383. So we have used data from: cab7e7a4.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for 306c74f8

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Manage               | 28     | 0      | 2       | 9     | ❗     |
| Protect              | 2      | 0      | 0       | 0     | ✅     |
| Plan                 | 41     | 0      | 1       | 1     | ❗     |
| Create               | 17     | 0      | 2       | 0     | ✅     |
| Verify               | 12     | 0      | 1       | 7     | ❗     |
| Configure            | 0      | 0      | 1       | 0     | ➖     |
| Package              | 0      | 0      | 1       | 0     | ➖     |
| Version sanity check | 0      | 0      | 1       | 0     | ➖     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 100    | 0      | 9       | 17    | ❗     |
+----------------------+--------+--------+---------+-------+--------+

added 137 commits

• 674ad4f7...41a52cb0 - 136 commits from branch master
• 1cbfd644 - With expired test suite, show message

Compare with previous version

changed the description

added 1 commit

• 30ec672f - With expired test suite, show message

Compare with previous version

added 1 commit

• 7e21ebfb - With expired test suite, show message

Compare with previous version

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

marked this merge request as ready

@gdoyle Would you do the UX review for this please?

added workflowin review label and removed workflowin dev label

requested review from @gdoyle

@himkp Could you review the frontend changes here? Thanks!

requested review from @himkp

approved this merge request

@gdoyle, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

removed review request for @gdoyle

approved this merge request

removed review request for @himkp

@jivanvl Would you do the maintainer review for this please?

requested review from @jivanvl

removed review request for @jivanvl

added 777 commits

• 7e21ebfb...b201bf83 - 775 commits from branch master
• 149c68c4 - With expired test suite, show message
• d7b77e8d - Remove utility class, use toBe instead of toEqual

Compare with previous version

added 457 commits

• d7b77e8d...cf66cae9 - 455 commits from branch master
• 64c5f438 - With expired test suite, show message
• 306c74f8 - Remove utility class, use toBe instead of toEqual

Compare with previous version

requested review from @jivanvl

resolved all threads

approved this merge request

Looks good to me! Thanks @mfluharty!

enabled an automatic merge when the pipeline for b5086f60 succeeds

merged

mentioned in commit cb78f14d

added workflowstaging-canary label and removed workflowin review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

mentioned in issue #296963 (closed)

added releasedcandidate label

removed documentation label