Set the size of `GlAvatarLink` to use in `app/assets/javascripts/diffs/components/diff_content.vue`
What does this MR do and why?
For #355861 (closed)
This MR sets the size on the user-avatar-link used in diff_content.vue to 48 (from 40, which is not supported by GlAvatar/GlAvatarLink) and removes some CSS that was pushing it in behind the comment box.
Screenshots or screen recordings
| without this MR | with this MR | |
|---|---|---|
| feature flag disabled |  |
 |
| feature flag enabled |  |
 |
Size options comparison
The two closest options to the old size, 40px:
| 32px | 48px |
|---|---|
 |
 |
How to set up and validate locally
- make a change to an image in a branch/MR
- navigate to the MR's diff
- click on the image to open the comment box
- your avatar should appear to the left of the comment box, 40px by 40px
git checkout 355861-gl-avatar-in-pending-image-diff-comments- refresh the page and click the image to open the comment box again
- your avatar should appear, this time 48px by 48px
echo "Feature.enable(:gl_avatar_for_all_user_avatars)" | rails c- refresh the page and click the image to open the comment box again
- your avatar should appear again, still 48px by 48px
optional cleanup: echo "Feature.disable(:gl_avatar_for_all_user_avatars)" | rails c
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miranda Fluharty