Skip to content

Replace generic checkbox with GitLab UI styled checkbox

Artur Fedorov requested to merge 358368-replace-checkbox-ldap-group into master

What does this MR do and why?

This MR resolves: #358368 (closed)

It resolves three Issues in one MR as otherwise it would be inconsistent from design perspective.

It replaces generic checkbox with GitLab UI styled checkbox

Describe in detail what your merge request does and why.

Screenshots or screen recordings

before
Screenshot_2022-04-18_at_19.28.00
after
Screenshot_2022-04-18_at_19.31.56

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

How to reproduce

You must first enable LDAP by editing gitlab-development-kit/gitlab/gitlab.yml and changing line 441 from enabled: false to enabled: true:

ksnip_20220408-154808
  1. Go to /groups/$GROUP_ID/-/ldap_group_links
  2. LDAP group settings are on top

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Artur Fedorov

Merge request reports