Skip to content

Fix unintended line breaks were inserted using Japanese IME on MacOS

Hiroyuki Sato requested to merge hiroponz/gitlab:handle-composition-event into master

What does this MR do and why?

Composition events are not taken into account in [markdown] When typing enter/return in a list, ... (!79161 - merged).

Therefore, using the Japanese IME on MacOS will break the list.

Screenshots or screen recordings

before after
before after

How to set up and validate locally

  1. Enable the markdown_continue_lists. 
    Feature.enable(:markdown_continue_lists)
  2. Visit any project.
  3. Create new issue.
  4. Using Japanese IME on MacOS to enter a list in a text area.

#358761 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hiroyuki Sato

Merge request reports