Skip to content

Fix: i18n issue for MRs and timeago.js

Wu Jeremy requested to merge gitlab-jh/jh-team/gitlab:fix/i18n-for-mr-and-timeago into master

What does this MR do and why?

  • Fix time value cannot be formatted with timeago.
  • Fix i18n issues for MRs.

Describe in detail what your merge request does and why.

For now, some time value cannot be formatted with the correct locale, see screenshot below:

MR time ago Pipeline
timeago_before pipeline_before

After:

MR time ago Pipeline
timeago_after pipeline_after

After the changes, no more mixed content for now, except the 137 job should also be translated, I couldn't figure out why it doesn't translate. Seems like the n_ method in Ruby works different when I tried to update the texts on page, if someone could help with that it'd be great.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports