Migrating user-avatar-link for diff_discussion_header.vue
What does this MR do and why?
Fixes #355868 (closed)
Ensures that updated user_avatar_link (that now uses GlAvatar) is properly displayed in MR discussion header (app/assets/javascripts/notes/components/diff_discussion_header.vue)
Screenshots or screen recordings
Before the update:
Flag disabled:
| desktop | mobile |
|---|---|
 |
 |
flag enabled
| desktop | mobile |
|---|---|
 |
 |
After the update:
Flag disabled
| desktop | mobile |
|---|---|
 |
 |
flag enabled
| desktop | mobile |
|---|---|
 |
 |
How to set up and validate locally
-
On your local instance open an (existing) MR, switch to "changes" tab and add a comment to some code line.
-
Switch to "Overview" tab and note how your comment looks like
-
Enable feature flag that would switch user_avatar_link to use the new version
Feature.enable(:gl_avatar_for_all_user_avatars) -
Check the MR comment again
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.