Skip to content

Fix Ruby 3 kwargs deprecation in ManifestTypeEnum

What does this MR do and why?

Extracted from our Ruby 3 branch: !70798 (comment 909718200)

It gives warnings on master which uses Ruby 2.7:

DEPRECATION WARNING: /Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/app/graphql/types/dependency_proxy/manifest_type_enum.rb:8: 
warning: Using the last argument as keyword parameters is deprecated; 
maybe ** should be added to the call
/Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/app/graphql/types/base_enum.rb:55: 
warning: The called method `value' is defined here 
(called from block in <class:ManifestTypeEnum> 
at /Users/lipton/dev/gitlab/gitlab-development-kit/gitlab/app/graphql/types/dependency_proxy/manifest_type_enum.rb:8)

It breaks on Ruby 3.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Aleksei Lipniagov

Merge request reports