Migrate add projects button to confirm variant
What does this MR do and why?
Changes the "Add projects" button from success
to confirm
.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mvanremmerden
- Resolved by Simon Knox
@tauriedavis Yet another one to review. This time three for the price of one
😁 Edited by Marcel van Remmerden
requested review from @tauriedavis
2 Warnings ⚠ Please add a merge request type to this merge request. ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+1)Simon Knox ( @psimyn
) (UTC+10)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c84cfe6f and c8f0ea20
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.44 MB 3.44 MB - 0.0 % mainChunk 1.92 MB 1.92 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Dangeradded Pajamas Migration Day UI polish UX frontend labels
added devopsverify sectionops + 1 deleted label
Allure report
allure-report-publisher
generated test report for c8f0ea20!review-qa-smoke:
📝 test report
review-qa-reliable:📝 test report👋 @tauriedavis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @tauriedavis
@psimyn Another review please
🙂 requested review from @psimyn
changed milestone to %14.10
enabled an automatic merge when the pipeline for 2963be44 succeeds
added 474 commits
-
011bde4b...c84cfe6f - 473 commits from branch
master
- c8f0ea20 - Migrate add projects button to confirm variant
-
011bde4b...c84cfe6f - 473 commits from branch
enabled an automatic merge when the pipeline for 6bc1a149 succeeds
mentioned in commit 8fafec15
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed devopsverify label
added FY23Q1 label