Revert Protected Environment group access inheritence
This is backport of !83573 (merged). There was a conflict with 14.9 ver so we need to manually resolve the conflict here.
FYI, the ProtectedEnvironment::DeployAccessLevel
business logic was moved to Authorizable
module in this MR.
Merge request reports
Activity
changed milestone to %14.9
assigned to @shinya.maeda
added grouprelease [DEPRECATED] label
- A deleted user
added typebug label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hordur Freyr Yngvason ( @hfyngvason
) (UTC-4, 13 hours behind@shinya.maeda
)Mark Chao ( @lulalala
) (UTC+8, 1 hour behind@shinya.maeda
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger@acook.gitlab Would you mind reviewing as backend reviewer? Thanks!
This is a backport process from !83573 (merged).
requested review from @acook.gitlab
changed milestone to %14.10
added missed:14.9 label
Allure report
allure-report-publisher
generated test report for 488fd8f3!review-qa-smoke:
test report
review-qa-reliable: test report@acook.gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 635b7b6d succeeds
mentioned in commit ee4ca8e0
mentioned in merge request gitlab-com/www-gitlab-com!102154 (merged)