Skip to content

Fix GlTable not displaying styles properly

Justin Ho Tuan Duong requested to merge 346921-tables-headers-should-have-no-background-out-of-the-box-2 into master

What does this MR do and why?

This MR cleans up CSS that overwrote gl-table styles.

Depends on gitlab-ui!2760 (merged) for some small style fixes.

Changelog: changed

Related to #346921 (closed)

Screenshots or screen recordings

Page Before After
Project > Pipeline show > Failed jobs Pipeline_show___Failed_jobs_before Pipeline_show___Failed_jobs_after
Admin > Background migrations Background_migrations_before Background_migrations_after
Project > Integrations GlTable_before GlTable_after

How to set up and validate locally

  1. For Project > Pipeline show > Failed jobs: http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/pipelines/63/failures
  2. For Admin > Background migrations: http://127.0.0.1:3000/admin/background_migrations?tab=finished
  3. For Project > Integrations: http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/settings/integrations

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Justin Ho Tuan Duong

Merge request reports