Skip to content

feat(GlTable): Add vertical-align: top to table th and td

Justin Ho Tuan Duong requested to merge justin_ho-add-vertical-align-to-table into main

What does this MR do?

As per this comment #1759 (comment 900275198), we should use vertical-align: top for both table headers and cells. This MR updates the CSS so we don't fallback to browser defaults.

Why now?

In GitLab the product, we have quite a few instances of GlTable. However, out of the box there are style mismatches between what is rendered and what GitLab UI prescribes (see gitlab#346921 (closed)).

This is due to conflicting styles from app/assets/stylesheets/framework/tables.scss. Some of these styles include vertical-align: top which is now being ported here. Once this gets merged, we should be able to remove those (or at least not apply them to tables with gl-table class).

Screenshots

Before After
Table_vertical_align_before Table_vertical_align_after

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Justin Ho Tuan Duong

Merge request reports