Remove scheduled and manual from STARTED_STATUSES constant

Allison Brownerequested to merge
cleanup-started-statuses into master

What does this MR do and why?

During the work on #273378 (closed) we discovered that the STARTED_STATUSES constant contains 2 statuses that are not relevant. The method is currently only used in one place in a buggy started? method.

The method started? which should return a boolean by convention returns a timestamp or false or nil. Currently this is exposed via internal json api. Because the method is internal only we don't have to release this as a breaking change.

We also created 2 MR's that made the front end only using started_at (so the serialization of job.started is no longer used).

!85513 (merged) and !85515 (merged).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Allison Browne

Merge request reports