Skip to content

Rspec for Stop pipelines and jobs when over_storage_limit

Suraj Tripathi requested to merge issue_348728_locking_artifact_creation into master

What does this MR do and why?

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/348735

When namespace storage limit is breached artifacts creation needs to be restricted, so as to avoid more breach of storage-limit, to stop creation of artifacts Pipeline and jobs are to be restricted. This MR just prevents Pipeline_creation when namespace storage is breached

Screenshots or screen recordings

Default Pipeline and Jobs pages, can "Run Pipeline" and "Retry" Jobs.

pretest-can-run-pipeline pretest-jobs-retry

After over_storage_limit? is breached Pipeline and Jobs pages, can't "Run Pipeline" and can't "Retry" Jobs, can't see "Editor'"

posttest-cant-run-pipeline post-test-no-job-retry posttest-pipeline-retry

How to set up and validate locally

Pre-Requiste

  • Setup Runner and verify local pipeline is getting triggered
  • Verify you can see the "Run Pipeline" button, navigate to <Project> > "CI/CD" > "Pipelines"
  • Verify you can access and run the pipeline via http://127.0.0.1:3000/<username>/<project>/-/pipelines/new
  • Verify you can see the "Retry" button, navigate to <Project> > "CI/CD" > "Jobs"
  • Verify you can see the "Editor" button under <Project> > "CI/CD"

Validate "creating a pipeline" when over_storage_limit? is true

  • Modify over_storage_limit? locally(for testing purposes), to return true
  • Verify you can't see the "Run Pipeline" button via UI <Project> > "CI/CD" > "Pipelines" anymore
  • Verify you can't access and run the pipeline via http://127.0.0.1:3000/<username>/<project>/-/pipelines/new it returns 404
  • curl for running pipeline returns 404
  • Verify "Editor" button is not visible, and access to the url returns 404
  • Verify "Retry" Job is not available under <Project> > "CI/CD" > "Jobs"
  • Verify "Retry" Pipleline results in 404

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Suraj Tripathi

Merge request reports