Add validation for namespace on compliance frameworks
What does this MR do and why?
- At the moment, it is possible to create a compliance framework via the GraphQL API associated with a personal namespace. However, if the framework is created it is not usable in any way.
- We would like to add support for personal namespaces at some point, but that support doesn't exist right now.
- This MR adds validation to ensure that the namespace is only a root, group namespace.
How to set up and validate locally
- Create a compliance framework using the
createComplianceFramework
graphQL mutation on:- A root group. (This should work.)
- A subgroup. (This should resolve to the root ancestor.)
- A personal namespace. (This should not work.)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #351739 (closed)
Merge request reports
Activity
changed milestone to %14.10
assigned to @mwoolf
added typemaintenance label
1 Warning e6a48d9f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend George Koltsov ( @georgekoltsov
) (UTC+1, same timezone as@mwoolf
)Kamil Trzciński ( @ayufan
) (UTC+2, 1 hour ahead of@mwoolf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-smoke:
test report
review-qa-reliable: test reportreview-qa-blocking:
test report for e6a48d9fexpand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 36 | 0 | 2 | 38 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Create | 23 | 0 | 2 | 23 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
added 1 commit
- 86b9dba6 - Add validation for namespace on compliance frameworks
added 1 commit
- aeab9105 - Add validation for namespace on compliance frameworks
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @proglottis
,@mayra-cabrera
,@rymai
,@eread
,@ifarkas
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in issue #351739 (closed)
- Resolved by Ethan Urie
@huzaifaiftikhar1 Could you do the initial review on this issue please?
requested review from @huzaifaiftikhar1
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
removed workflowin dev label
removed review request for @huzaifaiftikhar1
mentioned in issue gitlab-com/www-gitlab-com#13148 (closed)