Skip to content

Update group approval rules to settings

Daphne Kua requested to merge docs-dkua-update-to-group-approval-settings into master

What does this MR do?

The current documentation for Group-level settings for merge request approvals refers the settings as "rules".

This may be misleading since the actual group MR approval rules have not been implemented yet - epic: Group-level settings for merge request approval RULES in child projects.

Users may be expecting to find group MR rules, similar to those for projects.

At the moment the project MR approval "rules" and "settings" are segregated accordingly in

(1) docs:

image

(2) and GitLab UI

image


I have also added to the docs a link to the epic - not sure if the wording is alright?

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Merge request reports