Skip to content

Remove Vulnerability-Check approval rules frontend

Zamir Martins requested to merge remove_vulnerability_check into master

What does this MR do and why?

Remove Vulnerability-Check approval rules from frontend.

Backend changes will be part of this MR Migration of persisted data will be part of this MR

Documentation related MR: !86782 (merged)

Related issue: #357300 (closed)

Screenshots or screen recordings

Existing Vulnerability-Check rules under project settings

Screen_Shot_2022-04-27_at_5.35.41_PM

New approval rules under project settings

Screen_Shot_2022-04-27_at_5.36.01_PM

MR related approval rules

Screen_Shot_2022-04-27_at_5.43.22_PM

How to set up and validate locally

  1. Project -> Settings -> General -> Merge request approvals.

Expected that Vulnerability-Check rules won't be displayed unless existing.

  1. Navigate into any merge request with an existing Vulnerability-Check

Expected that Vulnerability-Check rule won't have a tooltip with link

**For a creation of a Vulnerability-Check rule revert this code and follow step (1) above. Select all scanners and create a new MR with the addition of .gitlab-ci.yml with the following content:

include:
  - template: Security/Container-Scanning.gitlab-ci.yml
container_scanning:
  variables:
    DOCKER_IMAGE: python:3.4-alpine

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zamir Martins

Merge request reports