Skip to content

Disallow deleting iterations that belong to an automatic cadence

Mario Celi requested to merge 353352-prevent-automatic-iteration-deletion into master

What does this MR do and why?

Automatic iterations cadences exist only behind the iteration_cadences feature flag. We are removing the ability to delete iterations from automatic cadences immediately and the entire mutation is already scheduled for removal in 16.0

Related to #353352 (closed)

How to set up and validate locally

  1. Make sure the iteration_cadences FF is disabled in the rails console (Feature.disable(:iteration_cadences))
  2. Visit the iterations menu inside the issues side menu of a group.
  3. Test that the legacy iterations feature works as expected. Should be able to delete an iteration if it belongs to a manaul cadence.
  4. Enable the iteration_cadences FF in the rails console (Feature.enable(:iteration_cadences))
  5. Visit http://localhost:3000/groups/gitlab-org/-/cadences
  6. Create an automatic iteration cadence.
  7. You should get an error if trying to delete iterations inside the new automatic iteration cadence using the following query in GraphiQL:
mutation {
  iterationDelete(input: {id: "gid://gitlab/Iteration/22"}) {
    errors
    group { id }
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mario Celi

Merge request reports