Skip to content

Resolve GlAvatar size in collapsed replies

Jiaan Louw requested to merge 355872-fix-gl-avatar-size-in-collapsed-replies into master

What does this MR do and why?

Updates the avatar size from 26 to 24 to resolve #355872 (closed) as part of the UserAvatarList migration to GlAvatar &7767 (closed).

Screenshots or screen recordings

MR replies

before + feature flag disabled before + feature flag enabled after + feature flag enabled
gdk.test_3000_h5bp_html5-boilerplate_-merge_requests_1__11 gdk.test_3000_h5bp_html5-boilerplate_-merge_requests_1__10 gdk.test_3000_h5bp_html5-boilerplate_-merge_requests_1__12

How to set up and validate locally

  1. Enable the feature flag by running: echo "Feature.enable(:gl_avatar_for_all_user_avatars)" | rails c
  2. View a merge request eligible approvers at: [GDK_HOST]/h5bp/html5-boilerplate/-/merge_requests/1
  3. Add a reply to a comment and collapse the replies to view the avatar list.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #355872 (closed).

Edited by Jiaan Louw

Merge request reports