Resolve GlAvatar size in MR approvals summary

What does this MR do and why?

Updates the avatar size from 20 to 24 to resolve #356453 (closed) as part of the UserAvatarList migration to GlAvatar &7767 (closed).

Screenshots or screen recordings

before + feature flag disabled	before + feature flag enabled	after + feature flag enabled

The footer is being updated in !83753 (merged).

How to set up and validate locally

1. Enable the feature flag by running: echo "Feature.enable(:gl_avatar_for_all_user_avatars)" | rails c
2. View a merge request at: [GDK_HOST]/h5bp/html5-boilerplate/-/merge_requests/1
3. Approve the merge request if no approvers are listed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #356453 (closed).

changed milestone to %14.10

added OKR-FY24Q2 frontend groupcompliance pajamasintegrate sectiondev severity4 typemaintenance workflowin dev + 1 deleted label

assigned to @jiaan

changed the description

changed the description

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

added 1 commit

• f453e855 - Resolve GlAvatar size in MR approvals summary

Compare with previous version

added feature flag label

marked this merge request as ready

	1 Warning
⚠	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.

	1 Message
📖	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Diana Zubova (@dzubova) (UTC+2, same timezone as @jiaan)	Kushal Pandya (@kushalpandya) (UTC+5.5, 3.5 hours ahead of @jiaan)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by 🚫 Danger

mentioned in merge request !83753 (merged)

changed the description

@janis could you please do the initial review?

requested review from @janis

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 07d5eba6 and f453e855

✨ Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.43 MB	3.42 MB	-9.17 KB	-0.3 %
mainChunk	1.92 MB	1.91 MB	-5.8 KB	-0.3 %

😨 Significant Growth: 3

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.operations.environments	334.12 KB	346.14 KB	+12.02 KB	3.6 %
pages.operations.index	462.24 KB	474.26 KB	+12.02 KB	2.6 %
pages.profiles.slacks	385.58 KB	395.47 KB	+9.89 KB	2.6 %

🎉 Significant Reduction: 7

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.epic_boards	2.11 MB	2.02 MB	-86.73 KB	-4.0 %
pages.projects.issues.index	3.04 MB	2.98 MB	-63.7 KB	-2.0 %
pages.admin.runners.index	1.34 MB	1.31 MB	-29.34 KB	-2.1 %
pages.dashboard.milestones.show	579.42 KB	559.63 KB	-19.79 KB	-3.4 %
pages.registrations.groups_projects.new	48.23 KB	46.62 KB	-1.61 KB	-3.3 %
pages.import.gitlab_projects.new	14.89 KB	13.67 KB	-1.23 KB	-8.2 %
pages.registrations.projects.new	28.31 KB	27.09 KB	-1.23 KB	-4.3 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for 07d5eba6. So we have used data from: d372b7c2.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by 🚫 Danger

mentioned in merge request !83837 (merged)

Allure report

allure-report-publisher generated test report for f453e855!

review-qa-smoke: 📝 test report
review-qa-reliable: 📝 test report

approved this merge request

👋 @janis, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

requested review from @kushalpandya

approved this merge request

resolved all threads

merged

mentioned in commit 1a7d4adb

added workflowstaging-canary label and removed workflowin dev label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added component:avatar label

added devopsfoundations label and removed 1 deleted label

mentioned in issue gitlab-org/incubation-engineering/jamstack/meta#63 (moved)

mentioned in issue gitlab-com/www-gitlab-com#14556 (closed)