Skip to content
Snippets Groups Projects

Expose cluster agents API link as field in project REST API

All threads resolved!

This change set exposes the _links.cluster_agent field in the GET /projects/** REST API endpoints, returned a basic project.

It addresses: #347047 (closed) and belongs to the epic &7204

/cc @nagyv-gitlab @nmezzopera @Alexand

Edited by See GitLab account @timofurrer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @msedlakjakubowski

  • changed milestone to %14.10

  • requested review from @mcelicalderonG

  • added 1 commit

    • 59525e79 - Link to issue in version note

    Compare with previous version

  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • added twfinished label and removed twdoing label

  • added 1 commit

    • 1d5f4dfa - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 832f6baf - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 4af417bc - Expose `agent_ids` field in project REST API

    Compare with previous version

  • added 1 commit

    • 78af6d85 - Expose `agent_ids` field in project REST API

    Compare with previous version

  • Mario Celi approved this merge request

    approved this merge request

  • Mario Celi requested review from @dbalexandre and removed review request for @mcelicalderonG

    requested review from @dbalexandre and removed review request for @mcelicalderonG

  • added 1 commit

    • b0f29799 - Expose `agent_ids` field in project REST API

    Compare with previous version

  • removed review request for @dbalexandre

  • mentioned in issue #355873 (closed)

  • mentioned in merge request !83270 (merged)

  • added 1 commit

    • 1720d329 - Expose `_links.cluster_agents` field in project REST API

    Compare with previous version

  • added 1 commit

    • 37d5fc0d - Expose `_links.cluster_agents` field in project REST API

    Compare with previous version

  • See GitLab account @timofurrer changed title from Expose {-agent_ids-} field in project REST API to Expose cluster agents API link as field in project REST API

    changed title from Expose {-agent_ids-} field in project REST API to Expose cluster agents API link as field in project REST API

  • See GitLab account @timofurrer changed the description

    changed the description

  • mentioned in issue #357320

  • removed review request for @msedlakjakubowski

  • added 3128 commits

    Compare with previous version

  • changed milestone to %15.0

  • requested review from @dbalexandre

  • added 1 commit

    • 3a33a29f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • resolved all threads

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Suggested Reviewers (beta)

    This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

    The individuals below may be good candidates to participate in the review based on various factors.

    After you review all recommendations, please assign reviewers manually, as this is not done automatically.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Reviewers
    @ngaskill, @afontaine, @rspeicher, @stanhu, @cablett

    If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for 12af6e3c succeeds

    enabled an automatic merge when the pipeline for 12af6e3c succeeds

  • @tuxtimo Thanks for your contribution :tada: This LGTM :thumbsup: I triggered a new pipeline and set MWPS :green_heart: :rocket:

  • Douglas Barbosa Alexandre canceled the automatic merge

    canceled the automatic merge

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for 12af6e3c succeeds

    enabled an automatic merge when the pipeline for 12af6e3c succeeds

  • 1 Warning
    :warning: 1be8825f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Documentation review

    The following files require a review from a technical writer:

    • doc/api/projects.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Allen Cook (@acook.gitlab) (UTC-4) Ethan Urie (@eurie) (UTC-4)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Generated by :no_entry_sign: Danger

  • @tuxtimo, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

  • mentioned in commit b7396cd2

  • mentioned in commit bd02fae5

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #403631 (closed)

  • Kati Paizee mentioned in issue #329219

    mentioned in issue #329219

  • Please register or sign in to reply
    Loading