Skip to content

Move BBM outer batching into job wrapper

Patrick Bair requested to merge pb-hoist-bbm-outer-batching-to-wrapper into master

What does this MR do and why?

Related to #357033 (closed)

To make it simpler and less error-prone to write batched background migrations, we want to move as much boilerplate as possible into the framework. Since we've seen so far that most BBM jobs follow a similar pattern of "sub-batching" over the job's batch, it makes sense to build an abstraction around that.

However, we still want to support "custom" batching that doesn't follow this particular model. Ideally the framework will simplify the common case, while having the flexibility to support the uncommon cases.

This MR rearranges some existing code to prepare to add the sub-batching into the framework.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Patrick Bair

Merge request reports