Skip to content

Swap sidebar attention requests source order

Thomas Randolph requested to merge tor/a11y/sidebar-attention-requests into master

What does this MR do and why?

For #351840 (closed)

Because the announced text of the sidebar assignees/reviewers is based on the source order, this MR reverses the order of the user & their attention request icon.

A screen reader should then announce who it is before announcing an action (e.g. "Request attention").

Screenshots or screen recordings

There's no change in the visual display, but the source order for the attention icon and the user avatar are flipped from the visual representation.

Before After
before__with_approval_ after__with_approval_

How to set up and validate locally

I've never been able to get a screenreader to work in a way I would assume is correct (almost all content is silent), so I'm not sure.

However, the pre-requisites for this feature are:

  1. Enable the mr_attention_requests feature flag
  2. Create a merge request with an assignee or a reviewer (or both)
  3. Optionally toggle any statuses of one of those users (like approving the MR with a reviewer, requesting attention from them, etc.)
  4. ?? (this is where the screen reader would announce the content on-screen)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Randolph

Merge request reports