Make spinner pajamas compliant for new branch
What does this MR do and why?
In this spinner, I updated the spinner to be PJ compliant per the instructions outlined in this Epic > &7628 (closed).
Since I had to remove the gl-spinner class and there were js specific logic attached to it:
- I also created a new specific class and updated the logic to point to that instead ->
js-create-mr-spinner. - In addition, I notice the use of our old style class
hide, so I updated that to use our new PJ compliant style class instead ->gl-display-none.
Screenshots or screen recordings
| Before | After (same as before) |
|---|---|
| before-new-branch | after-new-branch |
How to set up and validate locally
- Navigate to the issues page
- Select an issue
- You may want to refresh the page to see the spinner in action
- You will notice the spinner performs the same as before
| On refresh (no spinner) | Loading (spinner) | Done (no spinner) |
|---|---|---|
 |
 |
 |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #353743 (closed)
Edited by Samantha Ming