Fix compliance report prev button always returning to first page
requested to merge 356422-bug-compliance-violations-clicking-prev-always-returns-to-first-page into master
What does this MR do and why?
This MR resolves a typebug where clicking on Prev
always returned to the first page results as described in #356422 (closed).
This feature is hidden behind a default off feature flag.
Other known bugs:
- [Bug] Compliance violations merged_before/merge... (#356389 - closed)
- [Bug] Compliance violations pagination doesn't ... (#356408 - closed)
Screenshots or screen recordings
Screen_Recording_2022-03-22_at_14.42.41
How to set up and validate locally
- Have a GitLab Ultimate license.
- Checkout the branch from this MR !82989 (merged)
- Follow the setup steps in the MR above to generate violations.
- Checkout this branch
356422-bug-compliance-violations-clicking-prev-always-returns-to-first-page
. - View the report at
[GDK_HOST]/groups/[GROUP]/-/security/compliance_dashboard
. - Click
Next
at least twice. - Click
Prev
and confirm that you are on the previous page and not the first page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #356422 (closed)
Edited by Jiaan Louw