Fix vulnerability list clearing when already-selected filter is clicked
What does this MR do and why?
This MR fixes an issue on the vulnerability report where clicking on an already-selected filter will cause the vulnerability list to incorrectly blank out:
After the fix:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #356318 (closed)
Merge request reports
Activity
assigned to @dftian
mentioned in commit 654ea526
added 1 commit
- 654ea526 - Fix vulnerability list clearing when already-selected filter is clicked
1 Warning 
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Florie Guibert ( @fguibert) (UTC+10, 20 hours ahead of@dftian)Frédéric Caplette ( @f_caplette) (UTC-4, 6 hours ahead of@dftian)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b23f636c and 654ea526
Entrypoint / Name Size before Size after Diff Diff in percent average 3.7 MB 3.7 MB +1.43 KB 0.0 % mainChunk 2.32 MB 2.32 MB - 0.0 %
Note: We do not have exact data for b23f636c. So we have used data from: fed229f4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
requested review from @sming-gitlab
- Resolved by Natalia Tepluhina
@sming-gitlab Would you be able to do the initial review for this one?
- Last reply by Samantha Ming
Allure report
allure-report-publishergenerated test report for 654ea526!review-qa-reliable:
review-qa-smoke:removed review request for @sming-gitlab
@sming-gitlab, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Florie Guibert ( @fguibert) (UTC+10, 20 hours ahead of@dftian)Frédéric Caplette ( @f_caplette) (UTC-4, 6 hours ahead of@dftian)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
@ntepluhina Would you be able to do the maintainer review for this one?
requested review from @ntepluhina
@dftian thanks for the fix and for adding a nice test coverage for it!
enabled an automatic merge when the pipeline for b5c7a05b succeeds
mentioned in commit ae7134ae
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!918 (merged)
