Settings help text spacing fix
What does this MR do and why?
A small improvement to fix the spacing on settings pages for inputs and checkboxes help texts.
Screenshots or screen recordings
/admin/application_settings/repository
:
Type | Before | After |
---|---|---|
Input | ![]() |
![]() |
Checkboxes | ![]() |
![]() |
How to set up and validate locally
- Checkout the branch
- Navigate to
/admin/application_settings/repository
- Expand
Repository maintenance
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #356261 (closed)
Merge request reports
Activity
added UI polish UX devopsfoundations featureenhancement frontend groupcompliance sectiondev typefeature workflowsolution validation + 1 deleted label
assigned to @seggenberger
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %14.10
2 Warnings ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Janis Altherr ( @janis
) (UTC+1, same timezone as@seggenberger
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, same timezone as@seggenberger
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
🚫 Danger- Resolved by Natalia Tepluhina
removed featureenhancement label
added featureenhancement label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5a0af135 and f2ce40ef
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.7 MB 3.7 MB - -0.0 % mainChunk 2.32 MB 2.32 MB - 0.0 %
Note: We do not have exact data for 5a0af135. So we have used data from: de4a62d8.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Dangerremoved review request for @jiaan
removed workflowsolution validation label
- Resolved by Robert Hunt
removed review request for @rob.hunt
Allure report
allure-report-publisher
generated test report for f2ce40ef!review-qa-reliable:
📝 test report
review-qa-smoke:📝 test reportrequested review from @rob.hunt
mentioned in issue gitlab-design#1910 (closed)
requested review from @ntepluhina and removed review request for @rob.hunt
👋 @rob.hunt
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for cdaf5744 succeeds
mentioned in commit 9ffdce06
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label