Graceful degradation for refs endpoint
What does this MR do and why?
Contributes to #351520 (closed)
Problem
We have an unhandled exception when Gitaly is not available.
Solution
Return 503 error with an error message.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
There is no UI difference, because we equally handle 500 and 503 errors. However, now API responds with a structured error message and a proper http error code.
How to set up and validate locally
- Visit http://127.0.0.1:3000/flightjs/Flight/refs
- Disable Gitaly (
gdk stop gitaly
) - Visit http://127.0.0.1:3000/flightjs/Flight/refs
- Check that the response code is 503 and the response contains an error message.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.10
added backend groupsource code typebug labels
assigned to @vyaklushin
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jonathan Schafer ( @jschafer
) (UTC-5, 6 hours behind@vyaklushin
)James Fargher ( @proglottis
) (UTC+13, 12 hours ahead of@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermentioned in issue #351520 (closed)
Allure report
allure-report-publisher
generated test report for ebe9cdfc!review-qa-reliable:
test report
review-qa-smoke: test reportSetting label(s) Category:Source Code Management devopscreate sectiondev based on groupsource code.
added Category:Source Code Management devopscreate sectiondev labels
- Resolved by Marc Shaw
Hi @huzaifaiftikhar1!
Can you please review this fix?
requested review from @huzaifaiftikhar1
requested review from @marc_shaw and removed review request for @huzaifaiftikhar1
mentioned in issue gitlab-com/www-gitlab-com#13148 (closed)
@huzaifaiftikhar1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Catalin Irimie ( @cat
) (UTC+0, 1 hour behind@vyaklushin
)Dylan Griffith ( @DylanGriffith
) (UTC+11, 10 hours ahead of@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Marc Shaw
removed review request for @marc_shaw
added 989 commits
-
e8bfadb0...39da3930 - 988 commits from branch
master
- ebe9cdfc - Graceful degradation for refs endpoint
-
e8bfadb0...39da3930 - 988 commits from branch
requested review from @marc_shaw
enabled an automatic merge when the pipeline for c0c42898 succeeds
mentioned in commit 05ceec73
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in commit 3fabeae1
mentioned in commit c9754947
mentioned in commit 87c6163a
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!918 (merged)