Clarify local storage vs temp storage in WH uploads
What does this MR do and why?
A small follow-up to #351657 (closed)
I wanted to clarify in code the distinction between Workhorse using local storage for uploads in these two cases:
- It temporarily buffers a file to local or shared storage, even if object storage is available. This can happen e.g. because
direct_upload
is disabled, or unsupported for this particular upload. - It uploads to local storage as the final destination. This is in fact unsupported as of now, but we are considering to add this. In this case object storage is not enabled or available but WH might still upload to it directly.
This had confused me when looking at this code because IsLocal
suggested to me that WH was already doing the latter when in fact it didn't.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Matthias Käppler