Skip to content

Removed fetching unused properties for subscription

Vamsi Vempati requested to merge 352231-cleanup-unused-variables into master

What does this MR do and why?

Cleans up unused properties for subscription flow

With the bug fix for #352231 merged !82480 (merged), we no longer need guests and users for new subscription flow.

present_group is also used to fetch addon data, but it looks like users property wasn't actually being used in addon purchase flow. So I've removed both users and guests from being fetched.

Screenshots or screen recordings

Addon and subscription purchase flows behave as it used to

Minutes before purchase Purchase screen Minutes after purchase
Screen_Shot_2022-03-17_at_11.43.35_AM Screen_Shot_2022-03-17_at_11.46.15_AM Screen_Shot_2022-03-17_at_12.47.32_PM
Storage before purchase Purchase screen Storage after purchase
Screen_Shot_2022-03-17_at_11.43.24_AM Screen_Shot_2022-03-17_at_11.44.47_AM Screen_Shot_2022-03-17_at_11.45.59_AM
Subscription purchase
Screen_Shot_2022-03-17_at_12.51.04_PM

How to set up and validate locally

  1. Make sure self.com? return true in gitlab.rb
  2. Visit Usage quotas page for a group which has a project ex. http://localhost:3000/groups/test/-/usage_quotas?
    • Go to Pipelines tab and buy more minutes
    • Go to Storage tab and buy more storage

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vamsi Vempati

Merge request reports