Skip to content
Snippets Groups Projects

Check that possibleTypes for apollo are correct

Merged Lukas Eipert requested to merge leipert-graphql-types into master

What does this MR do and why?

When our GraphQL Union types or Interfaces change, we need to regenerate app/assets/javascripts/graphql_shared/possibleTypes.json. Not doing this has caused a regression before, so we create a little script to regenerate the types and check whether the checked in types are correct in CI.

This would have help prevent: !82833 (merged)

Fixes: #351896 (closed)

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 1f55fa41 and de472d6d

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.7 MB 3.7 MB - 0.0 %
    mainChunk 2.32 MB 2.32 MB - 0.0 %

    Note: We do not have exact data for 1f55fa41. So we have used data from: 6fe7f25b.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report for de472d6d!

    review-qa-smoke: :pencil: test report
    review-qa-reliable: :pencil: test report
    package-and-qa: :pencil: test report

  • Setting label groupfoundations based on @leipert's group.

  • Huzaifa Iftikhar
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading