Check that possibleTypes for apollo are correct
What does this MR do and why?
When our GraphQL Union types or Interfaces change, we need to regenerate app/assets/javascripts/graphql_shared/possibleTypes.json. Not doing this has caused a regression before, so we create a little script to regenerate the types and check whether the checked in types are correct in CI.
This would have help prevent: !82833 (merged)
Fixes: #351896 (closed)
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @leipert
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/lib/graphql.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/lib/graphql.js'
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Himanshu Kapoor ( @himkp
) (UTC+1, same timezone as@leipert
)Frédéric Caplette ( @f_caplette
) (UTC-4, 5 hours behind@leipert
)maintenanceworkflow / maintenancepipelines for CI, Danger Albert Salim ( @alberts-gitlab
) (UTC+8, 7 hours ahead of@leipert
)Albert Salim ( @alberts-gitlab
) (UTC+8, 7 hours ahead of@leipert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 2 commits
added 1 commit
- a713b86b - fixup! Check that possibleTypes for apollo are correct
marked this merge request as draft from a713b86b
added 11 commits
-
a713b86b...70921107 - 10 commits from branch
master
- 88b9d633 - Check that possibleTypes for apollo are correct
-
a713b86b...70921107 - 10 commits from branch
changed milestone to %14.9
added GraphQL frontend maintenanceworkflow typemaintenance labels
- Resolved by Vitaly Slobodin
@vitallium Could you review from a Frontend perspective?
@huzaifaiftikhar1 Could you review from an Engineering Productivity perspective?
Thank you!
requested review from @huzaifaiftikhar1 and @vitallium
assigned to @ntepluhina
- Resolved by Vitaly Slobodin
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1f55fa41 and de472d6d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.7 MB 3.7 MB - 0.0 % mainChunk 2.32 MB 2.32 MB - 0.0 %
Note: We do not have exact data for 1f55fa41. So we have used data from: 6fe7f25b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for de472d6d!review-qa-smoke:
test report
review-qa-reliable: test report
package-and-qa: test reportSetting label groupfoundations based on
@leipert
's group.added groupfoundations label
- Resolved by Huzaifa Iftikhar