Move rule to ApplicationSettingPolicy
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR moves the :update_runners_registration_token
rule from the global policy to the ApplicationSetting
policy, since that is where the runners_registration_token
setting lives. It also adapts the only place where that setting is used.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Part of #355637 (closed)
Merge request reports
Activity
changed milestone to %14.10
added [Deprecated] Category:Runner [Deprecated] Category:Runner Fleet devopsverify grouprunner sectionops + 1 deleted label
assigned to @pedropombeiro
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Maxime Orefice ( @morefice
) (UTC+1, same timezone as@pedropombeiro
)Nikola Milojevic ( @nmilojevic1
) (UTC+1, same timezone as@pedropombeiro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Jan Provaznik
Hey @serenafang
, mind doing the backend initial review?
requested review from @serenafang
@serenafang
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 129 commits
-
405f6b91...d14b5c3f - 128 commits from branch
master
- 9f1ce299 - Move rule to ApplicationSettingPolicy
-
405f6b91...d14b5c3f - 128 commits from branch
added 64 commits
-
9f1ce299...0ef34d11 - 63 commits from branch
master
- 885bffc6 - Move rule to ApplicationSettingPolicy
-
9f1ce299...0ef34d11 - 63 commits from branch
requested review from @jprovaznik
added typemaintenance label
Thanks @pedropombeiro, LGTM
, MWPS setenabled an automatic merge when the pipeline for 4e991c56 succeeds
mentioned in merge request !82721 (merged)
mentioned in commit 2158774b
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label