Skip to content

Remove finder from issues helper when vue_issues_list enabled

Coung Ngo requested to merge 355564-remove-finder-from-vue-issues-list into master

What does this MR do and why?

This MR removes the finder from the issues helper when the vue_issues_list feature flag is enabled. Its use here is not documented so we can remove it to clean up the code a bit (#355564 (comment 871181116)).

The issues controller was updated so that we continue setting the sort order when the vue_issues_list feature flag is enabled, since removing the finder removes setting the sort order.

Screenshots or screen recordings

How to set up and validate locally

  1. In rails console enable the feature flag 
    Feature.enable(:vue_issues_list)
  2. Visit any group or project issues list page such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/
  3. Test that the issues list page works fine

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #355564 (closed)

Edited by Coung Ngo

Merge request reports