Skip to content

Don't allow filtering by `in` alone on issue/MR dashboard

Patrick Bajao requested to merge 353992-fix-in-search-check into master

What does this MR do and why?

When in param is set while no search param is set, the issues and MRs finder won't use the in param. It'll instead skip the filter check and can result to SQL statement timeout.

The fix is to check that if in param is set but no search, show the "Please select at least one filter to see results" message.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. View issues/MRs dashboard with in param alone via http://gdk.test:3000/dashboard/issues?scope=all&state=opened&in=title or http://gdk.test:3000/dashboard/merge_requests?scope=all&state=opened&in=title.
  2. The Please select at least one filter to see results message should show up.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #353992

Merge request reports