Enable `container_registry_follow_redirects_middleware` by default
🌵 Context
In !81056 (merged), we fix a typebug with the Container Registry client.
We had a "custom" logic to follow redirect responses and faraday
(the http lib we use in the Container Registry client) can encode/decode query parameters. The problem is that the redirect response can point to a signed url. Query parameters in signed urls must not be modified at all, otherwise, the external backend will reject the request.
We fixed that issue by using the faraday
middleware to auto follow redirects.
The Container Registry client being quite central to all interactions with the Container Registry, we deployed this change behind a feature flag flag.
After an incremental rollout, the typebug has been fixed and we now want to deploy the fix to self-managed users.
Given that self-managed can use third party Container Registries and different storage backends there, we're choosing to enable the feature flag by default instead of removing the feature flag. This way, the feature flag acts as a safety net for self-managed users.
🤔 What does this MR do and why?
- Enable
container_registry_follow_redirects_middleware
feature flag by default.- Rollout issue: #353291 (closed).
🖼 Screenshots or screen recordings
See !81056 (merged)
🌽 How to set up and validate locally
See !81056 (merged)
🛃 MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.