Skip to content

Resolve "Audit usage of link variant in ee/app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_footer.vue"

Tomas Vik requested to merge 241595-audit-link-button-in-approvals-footer into master

What does this MR do and why?

This MR is part of the frontend pajamasintegrate initiative to migrate parts of our codebase to new pajamas components.

This MR changes buttons from link variant to tertiary button.

Screenshots or screen recordings

before after
view-eligible-approvers-before view-eligible-approvers-after-small
Screencast with medium-size button

This has been replaced with a small size button in the latest MR version.

view-eligible-approvers-after

How to set up and validate locally

  1. Add a license to your GDK since this is an enterprise feature
  2. Navigate to any MR, for example http://127.0.0.1:3000/flightjs/Flight/-/merge_requests/4
  3. See the new UI of the toggle buttons
    • Saepe_ducimus_magnam_officia_eligendi_corporis_fugiat_doloribus_quis_at____4____Merge_requests___Flightjs___Flight___GitLab

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #241595 (closed)

Edited by Tomas Vik

Merge request reports