Fix variable in _prometheus.html.haml so it shows as a code block
What does this MR do and why?
When loading /admin/application_settings/metrics_and_profiling
without a valid prometheus_multiproc_dir, a warning is supposed to show that your ENV variable or directory is not valid. This warning had an error where it would point to a variable that didn't exist, while it should've been pointing to a string, this MR fixes that.
Screenshots or screen recordings
How to set up and validate locally
Two things to validate:
(The first fails on the current master branch)
- Remove the directory that environment variable
prometheus_multiproc_dir
points to (default:gitlab/tmp/prometheus_multiproc_dir/puma
- Go to
<gdk-url>/admin/application_settings/metrics_and_profiling
- Expand
Metrics - Prometheus
, a warning should now show up (see screenshot above).
- (re)create the directory
- Go to
<gdk-url>/admin/application_settings/metrics_and_profiling
- Expand
Metrics - Prometheus
, a warning should not show up.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Fixes #352055
Edited by Roy Zwambag