Skip to content

Resolve "Return appropriate error when merge_request_diff_head_sha is not given"

Marc Shaw requested to merge 354093-return-appropriate-error-when-merge_request_diff_head_sha-is-not-given into master

What does this MR do and why?

The merge_request_diff_head_sha parameter is required when using the /merge quick action so to avoid merges when the diff has changed. Previously the command would fail without reason, now we explain the required parameter is missing.

To test

  • Create a mergeable merge request
  • Send an graphql or api request without the merge_request_diff_head_sha parameter. It should give a general error.
  • Change to this branch
  • Send the request again, and it should give a more detailed error

Related to #354093 (closed)

Edited by Marc Shaw

Merge request reports