change eq to match array
What does this MR do and why?
changes eq to match array
Describe in detail what your merge request does and why.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - When you feel your MR (merge request) is ready for a review, just ask
@gitlab-bot request_review
and someone will take a look. - If you are stuck, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
- You can provide feedback on the GitLab Contributor Experience in this survey
This message was generated automatically. You're welcome to improve it.
added Community contribution label
assigned to @rachelfox
@stanhu please review and merge
504 504 it 'does not update merge requests milestone' do 505 505 subject 506 506 507 epics.each { |epic| expect(epic.reload.labels).to eq([label1])} 507 epics.each { |epic| expect(epic.reload.labels).to match_array([label1])} @rachelfox I appreciate the contribution, but
eq
is no different thanmatch_array
since there is only 1 element. We only need to do the latter if the order doesn't matter.Thanks @stanhu
mentioned in issue gitlab-org/quality/triage-reports#6678 (closed)
mentioned in issue gitlab-org/quality/triage-reports#6776 (closed)
added backend groupproject management typefeature labels
added typemaintenance label and removed typefeature label
Setting label(s) devopsplan sectiondev based on groupproject management.
added devopsplan sectiondev labels
Hi @rachelfox,
We would love to know how you found your code review experience in this merge request! Please leave a
or a on this comment to describe your experience.Once done, please comment
@gitlab-bot feedback
below and feel free to leave any additional feedback you have in the same comment.You can also fill out a 5 minute survey to provided additional feedback on how GitLab can improve the contributor experience.
Thanks for your help!