Refactor JiraConnect dev info

What does this MR do and why?

This MR doesn't change the logic of how we construct the Jira dev info API call. It is only a refactoring to make it better testable.

Why is this needed?

I would like to reduce Gitaly N+1 requests by providing an option to exclude files from the commit entity. However, it is difficult to test the behavior of the dev info request.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %14.9

added JiraGitLab for Jira Cloud app backend groupintegrations [DEPRECATED] typemaintenance labels

assigned to @Andysoiron

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Eugie Limpin (@eugielimpin) (UTC+8, 8 hours ahead of @Andysoiron)	Ethan Urie (@eurie) (UTC-4, 4 hours behind @Andysoiron)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

marked this merge request as draft

added 1 commit

• 24e349d3 - Refactor JiraConnect dev info

Compare with previous version

marked this merge request as ready

Hi @.luke can you do the initial review on this MR?

requested review from @.luke

Setting label(s) devopsecosystem sectiondev based on ~"group::integrations".

added sectiondev + 1 deleted label

approved this merge request

@.luke, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

requested review from @alexkalderimis and removed review request for @.luke

added 569 commits

• 24e349d3...79341006 - 567 commits from branch master
• fd4c3986 - Refactor JiraConnect dev info
• 9f906c70 - Apply reviewer suggestion

Compare with previous version

approved this merge request

This is clearly a faithful refactoring - good luck with your performance improvement aims!

resolved all threads

enabled an automatic merge when the pipeline for c29f7a5a succeeds

merged

mentioned in commit 91ca8a2b

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in issue #356231 (closed)

@Andysoiron I think unfortunately we're going to have to revert this because I believe this change has been the cause of a lot of JiraConnect::SyncProjectWorker errors #356231 (closed). It's possibly just a very small logical change between what dev_info#present? means #356231 (comment 879217080), but I think the best course of action is to revert.

Thanks for reverting this @.luke I'll revisit this as part of #354370

mentioned in commit 08dc8472

mentioned in merge request !83149 (merged)

mentioned in issue #354370

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added devopsmanage label and removed 1 deleted label

added groupimport and integrate label and removed groupintegrations [DEPRECATED] label