Redact project bot name in UI
What does this MR do and why?
Describe in detail what your merge request does and why.
Note: needs rebase after !81843 (merged) and !81472 (merged)
If the current user cannot read the project or group that the bot belongs to, redact bot name in the UI.
Before:
Not signed in:
Signed in as a group member:
After:
Not signed in:
Signed in a a group member:
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added backend devopsmanage sectiondev + 1 deleted label
assigned to @serenafang
mentioned in merge request !81843 (merged)
Allure report
allure-report-publisher
generated test report for 53afcf5b!review-qa-reliable:
test report
review-qa-smoke: test report2 Warnings Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ryan Cobb ( @rcobb
) (UTC-8, 2 hours behind@serenafang
)Max Woolf ( @mwoolf
) (UTC+0, 6 hours ahead of@serenafang
)frontend Alexander Turinske ( @aturinske
) (UTC-7, 1 hour behind@serenafang
)Paul Slaughter ( @pslaughter
) (UTC-6, same timezone as@serenafang
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermentioned in merge request !82161 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7120 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7279 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7457 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7633 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7841 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8078 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8266 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8435 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8679 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8871 (closed)
mentioned in issue gitlab-org/quality/triage-reports#9048 (closed)
added 28472 commits
-
53afcf5b...f70efa51 - 28469 commits from branch
master
- 087524d7 - Redact project bot name in UI
- d2d61ebf - Add users helper spec
- ca7912f3 - Fix rubocop error
Toggle commit list-
53afcf5b...f70efa51 - 28469 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@mayra-cabrera
,@filipa
,@jivanvl
,@marin
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
3 Warnings This merge request changed frontend files without pretty printing them. Please add a merge request subtype to this merge request. This merge request does not refer to an existing milestone. Pretty print Frontend files
The following files should have been pretty printed with
prettier
:app/assets/javascripts/issuable/components/issue_assignees.vue
Please run
node_modules/.bin/prettier --write \ 'app/assets/javascripts/issuable/components/issue_assignees.vue'
Also consider auto-formatting on-save.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tyler Amos (
@tyleramos
) (UTC-5, 1 hour ahead of@serenafang
)Steve Abrams (
@sabrams
) (UTC-7, 1 hour behind@serenafang
)frontend Dheeraj Joshi (
@djadmin
) (UTC+5.5, 11.5 hours ahead of@serenafang
)Alexander Turinske (
@aturinske
) (UTC+9, 15 hours ahead of@serenafang
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @serenafang - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
added pipeline:run-as-if-foss label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6208a391 and 622730af
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - -0.0 % mainChunk 1.86 MB 1.86 MB - 0.0 %
Note: We do not have exact data for 6208a391. So we have used data from: 524e5d3a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in issue gitlab-org/quality/triage-reports#9601 (closed)
mentioned in issue gitlab-org/quality/triage-reports#9891 (closed)
mentioned in issue gitlab-org/quality/triage-reports#10075 (closed)
mentioned in issue #347362 (closed)
added 12438 commits
-
4c881d02...ba64e397 - 12434 commits from branch
master
- adc1ede8 - Redact project bot name in UI
- df788f86 - Add users helper spec
- a8595b0a - Fix rubocop error
- 622730af - Redact name in some parts of UI
Toggle commit list-
4c881d02...ba64e397 - 12434 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#10674 (closed)
mentioned in issue gitlab-org/quality/triage-reports#10912 (closed)
mentioned in issue gitlab-org/quality/triage-reports#11139 (closed)
mentioned in issue gitlab-org/quality/triage-reports#11316 (closed)
- Resolved by Nick Nguyen
Hi @serenafang
This MR came up in a recent triage report. I'm curious if you're still planning to continue this in the near future or if it's ok to close for now.
added devopsdata stores grouptenant scale sectioncore platform labels and removed devopsmanage sectiondev + 1 deleted label