Replace `data-confirm` modals with `GlModal` in `app/views/projects/artifacts/_artifact.html.haml`
requested to merge 344179-replace-data-confirm-modals-with-glmodal-in-app-views-projects-artifacts-_artifact-html-haml into master
What does this MR do and why?
Related to #344179 (closed) as part of &6854 (closed).
The confirm modal works as expected for the "
- Adds the
data-confirm-btn-variant="danger"
attribute to the button.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable the feature flag
Feature.enable(:bootstrap_confirmation_modals)
- Optionally enable the artifacts management page
Feature.enable(:artifacts_management_page)
- Visit
http://127.0.0.1:3000/gitlab-org/gitlab-test/-/artifacts
. You might need to run a job first. - Click the "
🗑 " button. - The confirm modal should show "Delete artifacts", and it'd delete it.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Axel García